Node.js 15 support (legacy) #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
changed the title
Closed
goto-bus-stop
force-pushed
the
node-15
branch
2 times, most recently
from
f126bb7 to
079db7d
Compare
|
Hrrm so it seems to work OK with Node.js 15 + npm 6, but with npm 7 it's a coin toss whether node-gyp succeeds or not. |
goto-bus-stop
changed the title
kjvalencik
approved these changes
Nov 23, 2020
|
This also appears to fix Neon on Apple M1 Macs. Most likely the |
* Add Node 15 to the build matrix * Force npm@6 on Windows with Node 15 * Check for `neon.obj` in two possible locations
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still failing on Rust beta and nightly, but Windows 10 + Rust stable + Node.js 15 does work with these changes.